fix: rollback prettier to 2ˆ to fix publishing issues #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icazevedo
requested review from
renatamottam and
lucasfp13
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0fe202c:
|
icazevedo
requested review from
hellofanny
and removed request for
renatamottam
eduardoformiga
approved these changes
Oct 9, 2023
hellofanny
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes this issue that happened while publishing packages due to incompatible
eslint-plugin-prettierversions with prettier 3.x.How it works?
In #2050 I upgraded the prettier version to 3.x. That caused the issue because
tsdxhas a dependency on an oldeslint-plugin-prettierversion, which is incompatible withprettier@3. I'm rolling back the upgrade and fixing the prettier version on the major2which makes it difficult for others to make the same mistake as me.In the future, we remove all uses of
tsdxas it is no longer supported and has gone 3 years without updates.How to test it?
By merging this!
References
prettier/eslint-plugin-prettier#562
Thanks @hellofanny for noticing the error and investigating it!