Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Attempt to fix the publishing #1426

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

filipewl
Copy link
Contributor

@filipewl filipewl commented Aug 1, 2022

What's the purpose of this pull request?

See the last merge commit in https://github.com/vtex/faststore/commits/main. Its CD / FastStore (push) check failed with an error lerna ERR! EPRESET Unable to load conventional-changelog preset 'conventionalcommits' (conventional-changelog-conventionalcommits).

We had recently changed the changelog preset from angular to conventionalcommits in #1425, but didn't get to test if it worked till now. I think it may be because we didn't install this conventional-changelog-conventionalcommits, but I'm not sure.

Note that when I tried to yarn add --dev conventional-changelog-conventionalcommits it first errored with:

▶ yarn add --dev conventional-changelog-conventionalcommits
yarn add v1.22.19
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if y
ou really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

So I used yarn add --dev conventional-changelog-conventionalcommits -W, but I'm not sure this is the correct way.

How to test it?

Not sure if this is going to work until this is merged and the action runs.

References

See the last merge commit in https://github.com/vtex/faststore/commits/main. Its *CD / FastStore (push)* check failed with an error [`lerna ERR! EPRESET Unable to load conventional-changelog preset 'conventionalcommits' (conventional-changelog-conventionalcommits)`](https://github.com/vtex/faststore/runs/7619824436?check_suite_focus=true#step:10:41).

_I think_ it may be because we didn't install this [`conventional-changelog-conventionalcommits`](https://github.com/conventional-changelog/conventional-changelog/tree/bfe3bf1c49d4a125474b398b2d304749fd3b56c7/packages/conventional-changelog-conventionalcommits), maybe?
@filipewl filipewl requested a review from a team as a code owner August 1, 2022 21:55
@filipewl filipewl self-assigned this Aug 1, 2022
@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 9:55PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 29434d2:

Sandbox Source
Store UI Typescript Configuration

Copy link
Member

@emersonlaurentino emersonlaurentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I used yarn add --dev conventional-changelog-conventionalcommits -W, but I'm not sure this is the correct way.

This is the correct way yes!

@filipewl
Copy link
Contributor Author

filipewl commented Aug 2, 2022

Let's try it then!

@filipewl filipewl merged commit 3b8e124 into main Aug 2, 2022
@filipewl filipewl deleted the chore/fix-changelog-sections-2 branch August 2, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants