Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Slider improvements #1415

Merged
merged 4 commits into from
Jul 25, 2022
Merged

chore: Slider improvements #1415

merged 4 commits into from
Jul 25, 2022

Conversation

lucasfp13
Copy link
Contributor

@lucasfp13 lucasfp13 commented Jul 22, 2022

What's the purpose of this pull request?

This PR intends to add the step prop to the Slider component and be adjustable on starters. Also, it fixes Slider's input range values to display only integer/precise number values.

Starters Deploy Preview

Related to nextjs.store's PR #146

@lucasfp13 lucasfp13 self-assigned this Jul 22, 2022
@vercel
Copy link

vercel bot commented Jul 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 3:13AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5541ced:

Sandbox Source
Store UI Typescript Configuration

@lucasfp13 lucasfp13 marked this pull request as ready for review July 22, 2022 18:47
@lucasfp13 lucasfp13 requested a review from a team as a code owner July 22, 2022 18:47
@lucasfp13 lucasfp13 merged commit e2e999b into main Jul 25, 2022
@lucasfp13 lucasfp13 deleted the chore/slider-improvements branch July 25, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants