feat(UI): Add Hero component #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 181cbfd:
|
eduardoformiga
approved these changes
Jun 2, 2022
Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com>
Thanks for reviewing! Just one starter PR in draft. I'll open it soonn ~ |
filipewl
approved these changes
Jun 3, 2022
Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is part of the Component Placement project, to bring some components from our starters (gatsby.store/nextjs.store).
How it works?
The
Herocomponent works together with its own wrapper components for each content's details:HeroImage: the wrapper component for the hero's image;HeroHeading: the wrapper component for the content (title, description and call to action link).How to test it?
Unit tests through Jest:
yarn test packages/ui/src/organisms/Hero/Hero.test.tsxReferences
Component Placement - FSSS-351