feat: Trade Policies #1319
Merged
feat: Trade Policies #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b67df2:
|
tlgimenes
force-pushed
the
chore/sales-channel
branch
from
c54c725 to
1283240
Compare
|
Deployment failed with the following error: |
tlgimenes
changed the title
| const postalCode = String(oldSession.postalCode ?? '').replace(/\D/g, '') | ||
| const country = oldSession.country ?? '' | ||
|
|
||
| const [regionData, sessionData] = await Promise.all([ |
There was a problem hiding this comment.
Change promise.all to promise.allSettled
There was a problem hiding this comment.
why allSettled is better in this case @igorbrasileiro?
emersonlaurentino
approved these changes
May 31, 2022
tlgimenes
force-pushed
the
chore/sales-channel
branch
from
3c078ed to
98d1ad4
Compare
tlgimenes
force-pushed
the
chore/sales-channel
branch
from
98d1ad4 to
43b859c
Compare
tlgimenes
force-pushed
the
chore/sales-channel
branch
from
43b859c to
5b67df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR uses
VTEX Sessionto add full support for trade policies on FastStoreHow it works?
We currently support a single trade policy by store on FastStore. You can configure your default trade policy at
store.config.js.Supporting multiple sales channels means we are able to automatically detect and change the channel based on multiple parameters, like user and urls.
To make this auto detection possible, I made the
Sessioncontext provider behave like theCartprovider. This means that it now accepts a new function calledonValidateSession. This functions calls the backend to validate the session. The backend, then, changes/validates the session and updates values like channel, person, language, etc.On any change to the channel (because the user is logged in, for instance) the session is updated and the user starts browsing on this new session.
To make all work, I:
userforpersononSessionContext. Now person can be accessed bysession.personpersonquery, since the person data is updated automatically on Session contextupdateSessionmutation in favor ofvalidateSessionHow to test it?
Test1:
storeframeworktostorecomponentsyarn develop/apparel---accessories. Make sure the list of products appear/apparel---accessories?sc=2. Make sure the product list changes.Test2:
storeframeworktostorecomponentsyarn developFASTSHOP TESTE HUB HML?sc=2. Make sure the currency changedStarters Deploy Preview
Future work
Requests for search api should wait for session validation. Currently these starters don't wait, causing possible flickering on the screen, since some products may appear and disappear (due to session being revalidated). Future work should include waiting for session validation before any requests.