chore(api): improve attachments performance #1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR improves attachments overall architecture. Related to #1304
How it works?
This PR organizes
additionalProperty
a little bit better, addspropertyID
to PropertyValues (which improves client-side performance) and fixes an inconsistency regarding attachments on thevalidateCart
mutation.How to test it?
JSON variables of the graphql query to the validateCart mutation:
Starters Deploy Preview
https://github.com/vtex-sites/nextjs.store/pull/47
vtex-sites/gatsby.store#53
References
This PR improves on #1304 by moving the propertyID computation to the backend