feat: Add OutOfStock component #1314
Conversation
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c728136:
|
ArthurTriis1
requested review from
renatamottam,
hellofanny,
eduardoformiga,
filipewl,
saranicoly and
lucasfp13
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
| expect(outOfStockMessage.tagName).toEqual('P') | ||
| }) | ||
|
|
||
| it('`outOfStockTitle` component should be an `paragraph`', () => { |
There was a problem hiding this comment.
I'm not sure about the title being a paragraph/div 🤔
The user could just use an heading tags.
| expect(outOfStockMessage.tagName).toEqual('P') | ||
| }) | ||
|
|
||
| it('`outOfStockTitle` component should be an `paragraph`', () => { |
Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
There was a problem hiding this comment.
I liked the change to the Component.InnerComponent pattern, but I'm unsure if this is the right moment to introduce it. Other components use a different pattern (e.g. ComponentInnerComponent). Maybe we open a discussion what which style to use? I feel like there are more pros to the former (e.g., only 1 import, autocomplete?), but I'm curious to know if there is any reason it hasn't been adopted from the start.
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Is a good point, a like this patter with dot, but while we don't have an opinion about this, I will change the pattern |
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com
What's the purpose of this pull request?
This PR is part of the
Component Placementproject, to bring some components from base.store.How it works?
Component in FastStore
Component in BaseStore
The
OutOfStockcomponent works together with its own others components:InputButtonHow to test it?
Unit tests through Jest: yarn test packages/ui/src/organisms/OutOfStock/OutOfStock.test.tsx
Starters Deploy Preview
References
Component Placement - FSSS-249