fix(api): Prevent throw error, when skus is empty

[igorbrasileiro]

What's the purpose of this pull request?

Prevent throw error when SKUs is empty, also missingSkus will be empty.

How it works?

How to test it?

base.store Deploy Preview

References

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 274f879:

Sandbox	Source
Store UI Typescript	Configuration

[eduardoformiga]

I tested it simulating the error and I think it's not working as expected since we won't have the missing SKUs on the error message.
"message": "Search API did not return the following skus: ",

Logs from the main local variables:

So I have a suggestion:

1. Maps the skus object as a key/value object.

const skus = skuIds.map((skuId) => ({
      key: skuId,
      value: skuBySkuId[skuId],
    }))

2. The missingSkus mapping the new key (sku).

const missingSkus = skus.filter((sku) => !sku.value).map((sku) => sku.key)

3. Keeps the original if and return the skus values:

if (missingSkus.length > 0) {
//...
}

return skus.map((sku) => sku.value)

logs after changes:

error message:
"message": "Search API did not return the following skus: 1010",

We can pair programming to discuss more :)

[igorbrasileiro]

I tested it simulating the error and I think it's not working as expected since we won't have the missing SKUs on the error message. "message": "Search API did not return the following skus: ",

Logs from the main local variables:

So I have a suggestion:

1. Maps the skus object as a key/value object.

const skus = skuIds.map((skuId) => ({
      key: skuId,
      value: skuBySkuId[skuId],
    }))

2. The missingSkus mapping the new key (sku).

const missingSkus = skus.filter((sku) => !sku.value).map((sku) => sku.key)

3. Keeps the original if and return the skus values:

if (missingSkus.length > 0) {
//...
}

return skus.map((sku) => sku.value)

logs after changes:

error message: "message": "Search API did not return the following skus: 1010",

We can pair programming to discuss more :)

Your change doesn't fix the problem, fix the error message. Yeah, I can fix the error message too. Thank you

[igorbrasileiro]

@eduardoformiga do you still think this change is necessary since now we're not using the checkout simulation?

[eduardoformiga]

@eduardoformiga do you still think this change is necessary since now we're not using the checkout simulation?

I think we are using the skuLoader in other places than the checkout simulation. Like in the product Query resolver, and the validateCart (image below). So it would be great to have the error message logging as expected, with the correct skus. But we can address it afterward as well. What do you think?