Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lighthouse-config): Increase the performance budget back to 95 #1201

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

igorbrasileiro
Copy link
Contributor

@igorbrasileiro igorbrasileiro commented Mar 31, 2022

What's the purpose of this pull request?

How it works?

How to test it?

base.store Deploy Preview

vtex-sites/base.store#439

References

@igorbrasileiro igorbrasileiro requested a review from a team as a code owner March 31, 2022 19:19
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc0b87b:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 📈

Are you planning to test it on the Base Store just to double-check we're consistently hitting this threshold?

@filipewl filipewl requested a review from a team March 31, 2022 19:49
@igorbrasileiro
Copy link
Contributor Author

Nice! 📈

Are you planning to test it on the Base Store just to double-check we're consistently hitting this threshold?

The score decreased again :/, I wasn't fast enough haha. But hold this PR.
vtex-sites/base.store#439

@igorbrasileiro igorbrasileiro force-pushed the chore/increase-budget branch from c14c626 to bc0b87b Compare April 18, 2022 16:39
@igorbrasileiro igorbrasileiro self-assigned this Apr 18, 2022
@igorbrasileiro igorbrasileiro merged commit 5a6171e into master Apr 19, 2022
@igorbrasileiro igorbrasileiro deleted the chore/increase-budget branch April 19, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants