fix(api): Add missing totalCount field to pageInfo in allCollections query
#1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhmp
changed the title
totalCount field to pageInfo in allCollections querytotalCount field to pageInfo in allCollections query
victorhmp
changed the title
totalCount field to pageInfo in allCollections querytotalCount field to pageInfo in allCollections query
victorhmp
changed the title
totalCount field to pageInfo in allCollections querytotalCount field to pageInfo in allCollections query
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40b4218:
|
gvc
approved these changes
Mar 16, 2022
eduardoformiga
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
The
allCollectionsquery always fails if the user asks for thepageInfo.totalCountfield, that is because the resolver for that query would never return that field.How it works?
Now the resolver will return the number of valid collections in the store when a user asks for
pageInfo.totalCount.How to test it?
I used the local server to test it (spoilers 🤫 ).
base.storeDeploy PreviewReferences