fix: StoreProduct return wrong sku #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for faststoreui ready! 🔨 Explore the source changes: ead7d41 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/62153a3c89f82000081120d1 😎 Browse the preview: https://deploy-preview-1156--faststoreui.netlify.app |
|
✔️ Deploy Preview for faststore-docs ready! 🔨 Explore the source changes: ead7d41 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/62153a3c6a91c10007f78567 😎 Browse the preview: https://deploy-preview-1156--faststore-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ead7d41:
|
1 task
igorbrasileiro
approved these changes
Feb 22, 2022
saranicoly
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes incorrect sku ids being returned on the sku field of StoreProduct.
How it works?
StoreProduct represents a sku on VTEX. StoreProductGroup represents a VTEX Product. As such, the
productIDandskufields of StoreProduct must have the same value. This was the case on stores with one sku per product, but not on accounts where multiple skus are present on each product.This PR uses the same logic for both
skuandproductIDso that they always have the same valuebase.storeDeploy PreviewMake sure that when adding a product to cart, this product shows on cart correctly.