Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Moves some Filter logic to api #1154

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Feb 21, 2022

What's the purpose of this pull request?

This PR is based on this comment and aims to move some logic from the Filter component from the frontend to the backend (API):

  • Sorts the facets values alphabetically
  • Removes the departamento facet from the Collection (PLP) page.

@eduardoformiga eduardoformiga requested a review from a team as a code owner February 21, 2022 22:50
@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: 8698773

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/62154ccc9921cc00076ccb82

😎 Browse the preview: https://deploy-preview-1154--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for faststore-docs ready!

🔨 Explore the source changes: 8698773

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/62154ccc11bd7a0008ab9882

😎 Browse the preview: https://deploy-preview-1154--faststore-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8698773:

Sandbox Source
Store UI Typescript Configuration

@eduardoformiga eduardoformiga changed the title feat: Moves some Filter logic to backend (api) feat: Moves some Filter logic to api Feb 21, 2022
Copy link
Contributor

@danzanzini danzanzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we can make all these changes at Faststore? Will these changes impact other systems using it?

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@eduardoformiga eduardoformiga merged commit 5a591f7 into master Feb 22, 2022
@eduardoformiga eduardoformiga deleted the feat/filter-search-results branch February 22, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants