-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Moves some Filter logic to api #1154
Conversation
✔️ Deploy Preview for faststoreui ready! 🔨 Explore the source changes: 8698773 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/62154ccc9921cc00076ccb82 😎 Browse the preview: https://deploy-preview-1154--faststoreui.netlify.app |
✔️ Deploy Preview for faststore-docs ready! 🔨 Explore the source changes: 8698773 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/62154ccc11bd7a0008ab9882 😎 Browse the preview: https://deploy-preview-1154--faststore-docs.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8698773:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we can make all these changes at Faststore? Will these changes impact other systems using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
What's the purpose of this pull request?
This PR is based on this comment and aims to move some logic from the
Filter
component from the frontend to the backend (API):departamento
facet from the Collection (PLP) page.