Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add budgets lighthouse config #1150

Merged
merged 7 commits into from
Feb 15, 2022
Merged

feat: Add budgets lighthouse config #1150

merged 7 commits into from
Feb 15, 2022

Conversation

tlgimenes
Copy link
Contributor

What's the purpose of this pull request?

This PR adds budgets to lighthouse config.

@tlgimenes tlgimenes requested a review from a team as a code owner February 14, 2022 18:51
@netlify
Copy link

netlify bot commented Feb 14, 2022 •
edited
Loading

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: d0c51fd

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/620ac7ec9f335d00071ad552

😎 Browse the preview: https://deploy-preview-1150--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Feb 14, 2022 •
edited
Loading

✔️ Deploy Preview for faststore-docs ready!

🔨 Explore the source changes: d0c51fd

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/620ac7ece12ed400080e40ee

😎 Browse the preview: https://deploy-preview-1150--faststore-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 14, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0c51fd:

Sandbox Source
Store UI Typescript Configuration

igorbrasileiro
igorbrasileiro approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but from where do you got those budgets?

@tlgimenes
Copy link
Contributor Author

LGTM, but from where do you got those budgets?

I got it from the base.store stats.

@tlgimenes tlgimenes mentioned this pull request Feb 14, 2022
Merged
@tlgimenes tlgimenes merged commit 60de848 into master Feb 15, 2022
@tlgimenes tlgimenes deleted the feat/budgets branch February 15, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbrasileiro igorbrasileiro igorbrasileiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlgimenes @igorbrasileiro