Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-nginx): remove trailing slash from incoming requests #1145

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

cezar-guimaraes
Copy link
Contributor

What's the purpose of this pull request?

Fix an issue with headers not being properly set when a requested page has an exact match, but the request URL contains a trailing slash.
Removing the trailing slash, however, introduced a problem where locations like /graphql/(.*) wouldn't work without the trailing slash. So we convert the regex generated to allow the trailing slash to be omitted.

How it works?

How to test it?

base.store Deploy Preview

References

@cezar-guimaraes cezar-guimaraes requested a review from a team as a code owner February 9, 2022 23:06
@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: d900804

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/62053fccf4816200099e350e

😎 Browse the preview: https://deploy-preview-1145--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for faststore-docs ready!

🔨 Explore the source changes: d900804

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/62053fcc771e0b00076f04c8

😎 Browse the preview: https://deploy-preview-1145--faststore-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d900804:

Sandbox Source
Store UI Typescript Configuration

@cezar-guimaraes
Copy link
Contributor Author

@cezar-guimaraes cezar-guimaraes merged commit db6f1e1 into master Feb 18, 2022
@cezar-guimaraes cezar-guimaraes deleted the fix/trailing-slash branch February 18, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants