feat(sdk): add item generics to analytics types for easy customization #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for faststoreui ready! 🔨 Explore the source changes: a3a05f7 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/61d73c76afbc44000735feeb 😎 Browse the preview: https://deploy-preview-1101--faststoreui.netlify.app |
|
✔️ Deploy Preview for faststore ready! 🔨 Explore the source changes: a3a05f7 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore/deploys/61d73c76e6ec080007de9177 😎 Browse the preview: https://deploy-preview-1101--faststore.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3a05f7:
|
icazevedo
changed the title
heitorado
approved these changes
Jan 7, 2022
igorbrasileiro
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR adds generics to the analytics events so users can control which type is used for the Item property. This makes it easier for additional properties to be included inside an item, which is a common use case.
How it works?
It defaults to the regular Item type but allows users to override it to include additional properties.
How to test it?
it shouldn't affect how the code behaves, only the dev experience.
base.storeDeploy PreviewI'll link it here as soon as I have it