Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Sku loader #1100

Merged
merged 2 commits into from
Jan 6, 2022
Merged

fix(api): Sku loader #1100

merged 2 commits into from
Jan 6, 2022

Conversation

tlgimenes
Copy link
Contributor

What's the purpose of this pull request?

The algorithm for the sku dataLoader was a little bit off. This PR fixes this problem by removing some edge cases that made errors like Could not find sku for product … from occuring

How to test it?

Link this PR with base.store and make sure you are able to open many different products

@tlgimenes tlgimenes requested a review from a team as a code owner January 6, 2022 15:01
@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: 7931b31

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/61d72e9cce81280007144537

😎 Browse the preview: https://deploy-preview-1100--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ Deploy Preview for faststore ready!

🔨 Explore the source changes: 7931b31

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore/deploys/61d72e9c0fb7180008b7b7c3

😎 Browse the preview: https://deploy-preview-1100--faststore.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7931b31:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@icazevedo icazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, LGTM, but I think we can enhance the debugging experience.

packages/api/src/platforms/vtex/loaders/sku.ts Outdated Show resolved Hide resolved
@tlgimenes tlgimenes merged commit 82d029f into master Jan 6, 2022
@tlgimenes tlgimenes deleted the fix/sku-loader branch January 6, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants