Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose JS files only #1081

Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix: expose JS files only #1081

merged 2 commits into from
Dec 15, 2021

Conversation

tlgimenes
Copy link
Contributor

What's the purpose of this pull request?

Make graphql-utils compatible with other frameworks

How it works?

graphql-utils was exposign the index file via typescript. This is ok when using Gatsby, however, other frameworks like Next.JS do not compile node_modules and may break when using this package. To solve this problem I'm just exposing the js file only

@tlgimenes tlgimenes requested a review from a team as a code owner December 15, 2021 15:16
@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: 83aa7c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/61ba0a5db84e180008588798

😎 Browse the preview: https://deploy-preview-1081--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for faststore ready!

🔨 Explore the source changes: 83aa7c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore/deploys/61ba0a5d7a4ecb00077beb32

😎 Browse the preview: https://deploy-preview-1081--faststore.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83aa7c1:

Sandbox Source
Store UI Typescript Configuration

Copy link

@rafaelbac rafaelbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlgimenes tlgimenes merged commit e363c12 into master Dec 15, 2021
@tlgimenes tlgimenes deleted the fix/browser branch December 15, 2021 16:11
tlgimenes added a commit that referenced this pull request Dec 20, 2021
* make browser point to dist

* fix lint
@igorbrasileiro
Copy link
Contributor

igorbrasileiro commented Dec 20, 2021

@tlgimenes, Were the Stores templates using gatsby updated their webpack setting to use the .ts file, so they can leverage from browserlist + webpack build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants