fix: Channel simulation #1014
Merged
fix: Channel simulation #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for faststoreui ready! 🔨 Explore the source changes: f2d0479 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/6182d51277081d000737ec42 😎 Browse the preview: https://deploy-preview-1014--faststoreui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2d0479:
|
lariciamota
approved these changes
Nov 3, 2021
tlgimenes
force-pushed
the
fix/channel-simulation
branch
from
d9986cf to
f2d0479
Compare
emersonlaurentino
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
When an SKU has sellers that are not available on the current sales channel, checkout breaks with
This PR fixes this problem
How it works?
To fix the aforementioned problem, we need to simulate only the sellers available for that specific sales channel. Hopefully, there is an attribute in the SKU that does just that. The fix is based on using this field instead of all skus's sellers.
Also, another problem this PR fixes is when the product has an empty array of images. This breaks the frontend code since we always need at least one image to show the product.
base.storeDeploy PreviewThis problem happens on
exitoaccount. To see it working, go to https://github.com/vtex-sites/exito.store/pull/1Also, to make sure no regressions were made: vtex-sites/base.store#96
References