fix(store-ui): Remove unnecessary ID and improve a11y #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 5f0542f 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/61200983f85bee000740b8ee 😎 Browse the preview: https://deploy-preview-915--storeui.netlify.app |
victorhmp
requested changes
Aug 20, 2021
| data-testid={testId} | ||
| aria-label="carousel" | ||
| > | ||
| <section data-store-carousel data-testid={testId} aria-label="carousel"> |
There was a problem hiding this comment.
This is actually necessary since we're using aria-controls on the arrows below. Without the id you should get another a11y error
victorhmp
requested changes
Aug 20, 2021
victorhmp
approved these changes
Aug 20, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f0542f:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
When we use the Carousel twice in the same page, the ID label decreases our A11y points in Lighthouse.