-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-ui): Create Badge component #894
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: f31a5f6 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6125058c2a42350007d684fa 😎 Browse the preview: https://deploy-preview-894--storeui.netlify.app |
Checked for stores using the current |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f31a5f6:
|
5e09d13
to
c424fec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @victorhmp 👏 !! Left some comments
fe06a7c
to
f752869
Compare
4a2923e
to
f31a5f6
Compare
What's the purpose of this pull request?
This PR adds the Badge component to our store-ui library.
Closes #832.
How it works?
The Badge component enables users to create their own discount (or any type of highlighted property) badges and add them to their UIs.
Here's an example on it being used to display a discount badge on top of some ProductSummary components:
How to test it?
Check the deploy preview below. You should find this under
Atoms/Badge
.