feat(store-ui): components migration to .tsx + .mdx and update storybook version to v6.3 #782
Conversation
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 6340289 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60ddee977cb63b0007a28b20 😎 Browse the preview: https://deploy-preview-782--storeui.netlify.app/ |
Gmantiqueira
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6340289:
|
Gmantiqueira
changed the title
| args={{ | ||
| value: 3.45, | ||
| variant: 'selling', | ||
| }} |
There was a problem hiding this comment.
It's sad that I can't see these args when I look into the code on the storybook. Is there a way we can show both the args and the function?
There was a problem hiding this comment.
@icazevedo Like this?
There was a problem hiding this comment.
But I'm not sure. I like the idea of showing how we are doing the formatter function. I'll test some things.
There was a problem hiding this comment.
I would like the best of both worlds: show all the args, but also show the function.
There was a problem hiding this comment.
Well, we can. We have the function in the Story tab and the values in the Show Code tab. I pushed this update just now.
There was a problem hiding this comment.
No way we can have the function and the values on the "Show code" section? 😢
There was a problem hiding this comment.
@icazevedo Nope :( We only have those two behaviors here: https://storybook.js.org/623cdb3c7a67ea4ce222bac6ede9cb59/button-story-code-doc-type-optimized.mp4
- Show literal code with variable names.
- Show the returned component with each value.
Idk if there's another way, but I think not.
There was a problem hiding this comment.
The docs of the docs hehe.
Gmantiqueira
changed the title
Gmantiqueira
changed the title
Gmantiqueira
force-pushed
the
storybook/migration-to-mdx
branch
from
3f48d62 to
6340289
Compare
What's the purpose of this pull request?
This PR migrates the rest of component docs to MDX in our Storybook.