fix: Cart item with additionalProperty (#1325)

* id non required * fix validateCart logic
vtex · May 30, 2022 · 8fa6aa1 · 8fa6aa1 · vercel · May 30, 2022
1 parent 5bce52b
commit 8fa6aa1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/packages/api/src/__generated__/schema.ts b/packages/api/src/__generated__/schema.ts
diff --git a/packages/api/src/platforms/vtex/resolvers/validateCart.ts b/packages/api/src/platforms/vtex/resolvers/validateCart.ts
@@ -5,6 +5,7 @@ import type {
   IStoreCart,
   IStoreOffer,
   IStoreOrder,
+  IStorePropertyValue,
 } from '../../../__generated__/schema'
 import type {
   OrderForm,
@@ -20,17 +21,18 @@ import {
 
 type Indexed<T> = T & { index?: number }
 
-const getAttachments = (item: IStoreOffer) =>
-  item.itemOffered.additionalProperty?.filter(
-    (i) => i.valueReference === VALUE_REFERENCES.attachment
-  )
+const isAttachment = (value: IStorePropertyValue) =>
+  value.valueReference === VALUE_REFERENCES.attachment
 
 const getId = (item: IStoreOffer) =>
   [
     item.itemOffered.sku,
     item.seller.identifier,
     item.price,
-    item.itemOffered.additionalProperty?.map(getPropertyId).join('-'),
+    item.itemOffered.additionalProperty
+      ?.filter(isAttachment)
+      .map(getPropertyId)
+      .join('-'),
   ]
     .filter(Boolean)
     .join('::')
@@ -59,7 +61,9 @@ const offerToOrderItemInput = (
   seller: offer.seller.identifier,
   id: offer.itemOffered.sku,
   index: offer.index,
-  attachments: (getAttachments(offer) ?? []).map((attachment) => ({
+  attachments: (
+    offer.itemOffered.additionalProperty?.filter(isAttachment) ?? []
+  ).map((attachment) => ({
     name: attachment.name,
     content: attachment.value,
   })),

diff --git a/packages/api/src/typeDefs/propertyValue.graphql b/packages/api/src/typeDefs/propertyValue.graphql
@@ -21,6 +21,10 @@ type StorePropertyValue {
 }
 
 input IStorePropertyValue {
+  """
+  Property id. This propert changes according to the content of the object.
+  """
+  propertyID: String
   """
   Property value. May hold a string or the string representation of an object.
   """