fix: Spot pricing sort for lowPrice/highPrice (#1350)

* fix pricing for lowPrice * exact types
vtex · Jun 9, 2022 · 6836c6f · 6836c6f · vercel · Jun 9, 2022
1 parent 1e8d1cf
commit 6836c6f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/api/src/platforms/vtex/resolvers/aggregateOffer.ts b/packages/api/src/platforms/vtex/resolvers/aggregateOffer.ts
@@ -1,4 +1,4 @@
-import { inStock } from '../utils/productStock'
+import { inStock, price } from '../utils/productStock'
 import type { StoreProduct } from './product'
 import type { PromiseType } from '../../../typings'
 import type { Resolver } from '..'
@@ -10,13 +10,14 @@ export const StoreAggregateOffer: Record<string, Resolver<Root>> & {
 } = {
   highPrice: (offers) => {
     const availableOffers = offers.filter(inStock)
+    const highOffer = availableOffers[availableOffers.length - 1]
 
-    return availableOffers[availableOffers.length - 1]?.Price ?? 0
+    return highOffer != null ? price(highOffer) : 0
   },
   lowPrice: (offers) => {
-    const availableOffers = offers.filter(inStock)
+    const [lowOffer] = offers.filter(inStock)
 
-    return availableOffers[0]?.Price ?? 0
+    return lowOffer ? price(lowOffer) : 0
   },
   offerCount: (offers) => offers.length,
   priceCurrency: () => '',

diff --git a/packages/api/src/platforms/vtex/utils/productStock.ts b/packages/api/src/platforms/vtex/utils/productStock.ts
@@ -10,7 +10,7 @@ export const sellingPrice = (offer: CommertialOffer) => offer.Price ?? 0
 export const availability = (available: boolean) =>
   available ? 'https://schema.org/InStock' : 'https://schema.org/OutOfStock'
 
-// Smallest Available Selling Price First
+// Smallest Available Spot Price First
 export const bestOfferFirst = (
   a: Pick<CommertialOffer, 'AvailableQuantity' | 'spotPrice'>,
   b: Pick<CommertialOffer, 'AvailableQuantity' | 'spotPrice'>