chore: Best offer first (#1184)

vtex · Mar 23, 2022 · 66c8f36 · 66c8f36
1 parent 3481f23
commit 66c8f36
Show file tree

Hide file tree

Showing 3 changed files with 89 additions and 12 deletions.
diff --git a/packages/api/src/platforms/vtex/resolvers/aggregateOffer.ts b/packages/api/src/platforms/vtex/resolvers/aggregateOffer.ts
@@ -3,17 +3,38 @@ import type { Simulation } from '../clients/commerce/types/Simulation'
 
 type Resolvers = (root: Simulation & { product: EnhancedSku }) => unknown
 
+const inStock = (item: Simulation['items'][0]) =>
+  item.availability === 'available'
+
+// Smallest Available Selling Price First
+export const sortOfferByPrice = (
+  items: Simulation['items']
+): Simulation['items'] =>
+  items.sort((a, b) => {
+    if (inStock(a) && !inStock(b)) {
+      return -1
+    }
+
+    if (!inStock(a) && inStock(b)) {
+      return 1
+    }
+
+    return a.sellingPrice - b.sellingPrice
+  })
+
 export const StoreAggregateOffer: Record<string, Resolvers> = {
-  highPrice: ({ items }) =>
-    items.reduce(
-      (acc, curr) => (acc > curr.sellingPrice ? acc : curr.sellingPrice),
-      items[0]?.sellingPrice ?? 0
-    ) / 1e2,
-  lowPrice: ({ items }) =>
-    items.reduce(
-      (acc, curr) => (acc < curr.sellingPrice ? acc : curr.sellingPrice),
-      items[0]?.sellingPrice ?? 0
-    ) / 1e2,
+  highPrice: ({ items }) => {
+    const availableItems = items.filter(inStock)
+    const highPrice = availableItems.pop()?.sellingPrice
+
+    return (highPrice ?? 0) / 1e2
+  },
+  lowPrice: ({ items }) => {
+    const availableItems = items.filter(inStock)
+    const lowPrice = availableItems[0]?.sellingPrice
+
+    return (lowPrice ?? 0) / 1e2
+  },
   offerCount: ({ items }) => items.length,
   priceCurrency: () => '',
   offers: ({ items, product }) => items.map((item) => ({ ...item, product })),

diff --git a/packages/api/src/platforms/vtex/resolvers/product.ts b/packages/api/src/platforms/vtex/resolvers/product.ts
@@ -1,6 +1,7 @@
+import { slugify } from '../utils/slugify'
 import type { Resolver } from '..'
 import type { EnhancedSku } from '../utils/enhanceSku'
-import { slugify } from '../utils/slugify'
+import { sortOfferByPrice } from './aggregateOffer'
 
 type Root = EnhancedSku
 
@@ -81,7 +82,11 @@ export const StoreProduct: Record<string, Resolver<Root>> = {
 
     const simulation = await simulationLoader.load(items)
 
-    return { ...simulation, product }
+    return {
+      ...simulation,
+      items: sortOfferByPrice(simulation.items),
+      product,
+    }
   },
   isVariantOf: ({ isVariantOf }) => isVariantOf,
   additionalProperty: ({ attributes = [] }) =>

diff --git a/packages/api/test/vtex.aggregateOffer.test.ts b/packages/api/test/vtex.aggregateOffer.test.ts
@@ -0,0 +1,51 @@
+import { sortOfferByPrice } from '../src/platforms/vtex/resolvers/aggregateOffer'
+
+describe('AggregateOffer', () => {
+  it('Should return best offers first', () => {
+    const sorted = sortOfferByPrice([
+      {
+        sellingPrice: 10,
+        availability: 'available',
+      },
+      {
+        sellingPrice: 20,
+        availability: 'unavailable',
+      },
+      {
+        sellingPrice: 30,
+        availability: 'available',
+      },
+      {
+        sellingPrice: 10,
+        availability: 'unavailable',
+      },
+      {
+        sellingPrice: 1,
+        availability: 'available',
+      },
+    ] as any)
+
+    expect(sorted).toEqual([
+      {
+        sellingPrice: 1,
+        availability: 'available',
+      },
+      {
+        sellingPrice: 10,
+        availability: 'available',
+      },
+      {
+        sellingPrice: 30,
+        availability: 'available',
+      },
+      {
+        sellingPrice: 10,
+        availability: 'unavailable',
+      },
+      {
+        sellingPrice: 20,
+        availability: 'unavailable',
+      },
+    ])
+  })
+})