fix: page view event trigger #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lariciamota
added a commit
to vtex/faststore
that referenced
this pull request
Dec 11, 2024
## What's the purpose of this pull request? Change the moment in which the page_view event is sent. It was previously being sent only during a page change, so it wasn't sent on the initialization of the page. ## How it works? Instead of watching the `routeChangeComplete` route event, now it sends the page_view event when the page is loaded. ## How to test it? Check on the starter preview that the store is working as expected. The real impact of this change will be tested in the next PR, in which the RC events will start to be sent. ### Starters Deploy Preview https://sfj-59f6820--starter.preview.vtex.app/ ([PR](vtex-sites/starter.store#631)) ## References - [GA page view](https://developers.google.com/analytics/devguides/collection/ga4/views) - [Jira task](https://vtex-dev.atlassian.net/browse/SFS-1798) - [Slack thread](https://vtex.slack.com/archives/C03L3CRCDC4/p1733837843137469)
emersonlaurentino
pushed a commit
to vtex/faststore
that referenced
this pull request
Jan 10, 2025
## What's the purpose of this pull request? Change the moment in which the page_view event is sent. It was previously being sent only during a page change, so it wasn't sent on the initialization of the page. ## How it works? Instead of watching the `routeChangeComplete` route event, now it sends the page_view event when the page is loaded. ## How to test it? Check on the starter preview that the store is working as expected. The real impact of this change will be tested in the next PR, in which the RC events will start to be sent. ### Starters Deploy Preview https://sfj-59f6820--starter.preview.vtex.app/ ([PR](vtex-sites/starter.store#631)) ## References - [GA page view](https://developers.google.com/analytics/devguides/collection/ga4/views) - [Jira task](https://vtex-dev.atlassian.net/browse/SFS-1798) - [Slack thread](https://vtex.slack.com/archives/C03L3CRCDC4/p1733837843137469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
How does it work?
How to test it?
Faststore related PRs
References