generated from vtex-sites/base.store
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Canonical PDP slugs #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment failed with the following error:
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-a88ecbc--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit a88ecbc
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
renatamottam
added a commit
that referenced
this pull request
Jun 3, 2022
* Creates Input Radio * Styles Radio * Adds Radio to Storybook * Adds tokens tables * Fixes Storybook table width * Fixes Checkbox hovers * Updates Changelog * Fix typo Co-authored-by: Fanny Chien <fannychienn@gmail.com> * Updates Checkbox Story to use TokenTable Co-authored-by: Fanny Chien <fannychienn@gmail.com>
renatamottam
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Feat: Adds tokens to `Radio` (#87) * Creates Input Radio * Styles Radio * Adds Radio to Storybook * Adds tokens tables * Fixes Storybook table width * Fixes Checkbox hovers * Updates Changelog * Fix typo Co-authored-by: Fanny Chien <fannychienn@gmail.com> * Updates Checkbox Story to use TokenTable Co-authored-by: Fanny Chien <fannychienn@gmail.com> * Updates Changelog * Updates RadioProps to add FSUI props Co-authored-by: Eduardo Formiga <eduardo.formiga@vtex.com.br> * Tweaks `Radio` token list order Co-authored-by: Fanny Chien <fannychienn@gmail.com> Co-authored-by: Eduardo Formiga <eduardo.formiga@vtex.com.br>
9603e1b
to
39e9f37
Compare
f0bd00e
to
34f5f8c
Compare
emersonlaurentino
approved these changes
Jun 8, 2022
483ecc0
to
dafc6a9
Compare
6e32a54
to
a7bc366
Compare
a7bc366
to
375c89a
Compare
375c89a
to
fce6305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Make migrations easier. More info at: vtex/faststore#1338