Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Canonical PDP slugs #87

Merged
merged 2 commits into from
Jun 13, 2022
Merged

feat: Canonical PDP slugs #87

merged 2 commits into from
Jun 13, 2022

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Jun 2, 2022

What's the purpose of this pull request?

Make migrations easier. More info at: vtex/faststore#1338

@vercel
Copy link

vercel bot commented Jun 2, 2022

Deployment failed with the following error:

Resource is limited - try again in 1 minute (more than 100, code: "api-deployments-free-per-day").

@vtex-sites
Copy link

vtex-sites bot commented Jun 2, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-a88ecbc--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit a88ecbc

@vtex-sites
Copy link

vtex-sites bot commented Jun 2, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit a88ecbc

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@vercel
Copy link

vercel bot commented Jun 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 6:14PM (UTC)

renatamottam added a commit that referenced this pull request Jun 3, 2022
* Creates Input Radio

* Styles Radio

* Adds Radio to Storybook

* Adds tokens tables

* Fixes Storybook table width

* Fixes Checkbox hovers

* Updates Changelog

* Fix typo

Co-authored-by: Fanny Chien <fannychienn@gmail.com>

* Updates Checkbox Story to use TokenTable

Co-authored-by: Fanny Chien <fannychienn@gmail.com>
renatamottam pushed a commit that referenced this pull request Jun 7, 2022
* Feat: Adds tokens to `Radio` (#87)

* Creates Input Radio

* Styles Radio

* Adds Radio to Storybook

* Adds tokens tables

* Fixes Storybook table width

* Fixes Checkbox hovers

* Updates Changelog

* Fix typo

Co-authored-by: Fanny Chien <fannychienn@gmail.com>

* Updates Checkbox Story to use TokenTable

Co-authored-by: Fanny Chien <fannychienn@gmail.com>

* Updates Changelog

* Updates RadioProps to add FSUI props

Co-authored-by: Eduardo Formiga <eduardo.formiga@vtex.com.br>

* Tweaks `Radio` token list order

Co-authored-by: Fanny Chien <fannychienn@gmail.com>
Co-authored-by: Eduardo Formiga <eduardo.formiga@vtex.com.br>
@tlgimenes tlgimenes changed the title feat: Canonical PDP slugs | WIP feat: Canonical PDP slugs Jun 7, 2022
@tlgimenes tlgimenes added the Features New feature or request label Jun 7, 2022
@tlgimenes tlgimenes force-pushed the fix/pdp-migration branch from 9603e1b to 39e9f37 Compare June 7, 2022 20:08
@tlgimenes tlgimenes force-pushed the fix/pdp-migration branch from f0bd00e to 34f5f8c Compare June 7, 2022 20:33
@tlgimenes tlgimenes merged commit a88ecbc into main Jun 13, 2022
@tlgimenes tlgimenes deleted the fix/pdp-migration branch June 13, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants