This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
chore: Improve useStorage and validateCart performance #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for basestore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-416--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m PerformanceLighthouse report
|
igorbrasileiro
force-pushed
the
chore/improve-use-storage
branch
4 times, most recently
from
fcd1ccb to
a41e888
Compare
|
Pay attention the result of lhci for PLP page, isn't right.
Page result - https://sfj-f054c7b--base.preview.vtex.app/
|
igorbrasileiro
force-pushed
the
chore/improve-use-storage
branch
from
a41e888 to
f054c7b
Compare
igorbrasileiro
changed the title
igorbrasileiro
force-pushed
the
chore/improve-use-storage
branch
from
f054c7b to
232707f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Description here: vtex/faststore#1186
How does it work?
Tell us the role of the new feature, or component, in its context.
How to test it?
Describe the steps with bullet points. Is there any external reference, link, or example?
References
Spread the knowledge: is this any content you used to create this PR that is worth sharing?
Extra tip: add references to related issues or mention people important to this PR may be good for the documentation and reviewing process
Checklist
You may erase this after checking them all ;)