This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
chore: Remove inline styles #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for basestore ready! 🔨 Explore the source changes: ac7cb08 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/6239b6183ee74c000880a581 😎 Browse the preview: https://deploy-preview-408--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-408--base.preview.vtex.app |
|
Did it increased the CLS? Or still the same? |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
igorbrasileiro
approved these changes
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR replaces inline <style/> tags by tags.
How does it work?
Inlining styles is good technique for decreasing FCP. It, however, increases TBT, since the browser processes both CSS and HTML in one go, instead of processing them on two different tasks.
This PR moves inline styles to an isolated stylesheet and removes CSS code splitting for the sake of simplicity.
FCP shouldn't be penalized that much since this CSS is hashed and has an
immutablecache header, which is heavily cached by the CDN.Moving inline styles to a custom sheet is not natively supported by gatsby, so a hack had to be made. This hack is described in here: gatsbyjs/gatsby#1526
How to test it?
Nothing should have changed visually. However, PSI score should be bigger than master
Checklist