This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Chore: Rename Badge variants
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 49880a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/622b6951a629fd0009914985 😎 Browse the preview: https://deploy-preview-381--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-381--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
To not compromise the semantic meaning of
Badgevariants usage, I suggest renaming the variants with a general purpose.BadgeVariants = 'neutral' | 'info' | 'highlighted'For the product card context, the previous options ('outOfStock' | 'new' | 'recommended' | 'neutral') suit very well . But we are also using the Badge in different contexts such as CartSidebar, Filter, Suggestions.
How does it work?
Nothing changes visually.
Some examples of current use:
Badge variant="neutral"
Badge variant="info"
How to test it?
Badgescolors on Filters and CartSideBar remains the same as http://base.vtex.appReferences
Checklist
You may erase this after checking them all ;)