This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
chore: Remove hooks folder #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 1f9fd71 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/622f8271d20da50008766913 😎 Browse the preview: https://deploy-preview-377--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-377--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 9m PerformanceLighthouse report
|
filipewl
approved these changes
Mar 8, 2022
eduardoformiga
approved these changes
Mar 8, 2022
victorhmp
suggested changes
Mar 11, 2022
tlgimenes
force-pushed
the
chore/homogeneous
branch
from
c157eab to
32bbc42
Compare
tlgimenes
force-pushed
the
chore/homogeneous
branch
from
32bbc42 to
2fe8173
Compare
tlgimenes
force-pushed
the
chore/homogeneous
branch
from
7967dd8 to
1f9fd71
Compare
victorhmp
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR removes the hooks folder.
How does it work?
The main idea of the
sdkfolder is to contain hooks with business logic that are used across the app. Turns out a new folderhookswas created, which lead to duplication of purposes on the filesystem.This PR unifies both hooks and sdk folders. Initially, I thought about moving the files "as is" from hooks to sdk, however, a closer inspection revealed that hooks on the
hooksfolder were only being used in a single file. I then, decided to inline these functions with the intent of having a smaller code base.How to test it?
Everything should work as before
Checklist