-
Notifications
You must be signed in to change notification settings - Fork 5
Chore: tweaks PLP loading [FSSS-211] #362
Chore: tweaks PLP loading [FSSS-211] #362
Conversation
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: c227613 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/6227c1ec866f8b00070a8603 😎 Browse the preview: https://deploy-preview-362--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-362--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job! 💯
Just noticed a strange scroll behavior that I'm not sure if is correct:
- When selecting some facet the page scrolls to the top (desktop version);
Screen.Recording.2022-02-23.at.01.03.45.mov
- When opening the
Filter
component the page scrolls to the top (mobile version).
Screen.Recording.2022-02-23.at.01.02.47.mov
Is it expected?
Nice catch! I think it's not expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's the purpose of this pull request?
As now we have the Skeleton, we can change some logic regarding the loading on PLP:
useTotalCount
hook.Skeleton
fromSort
andFilter
Button once.Filter
while using the mobile version.How to test it?
compare one of the previous deploy versions with the preview from this branch using the PLP or Search page.
Checklist