Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Chore: tweaks PLP loading [FSSS-211] #362

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Feb 22, 2022

What's the purpose of this pull request?

As now we have the Skeleton, we can change some logic regarding the loading on PLP:

  • Removes the useTotalCount hook.
  • Aims to load Skeleton from Sort and Filter Button once.
  • Keep the latest expanded items from Filter while using the mobile version.
BEFORE AFTER
Desktop UofWl3J8cM after desktop loading
Mobile before mobile after mobile

How to test it?

compare one of the previous deploy versions with the preview from this branch using the PLP or Search page.

Checklist

  • CHANGELOG entry added

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for basestore ready!

🔨 Explore the source changes: c227613

🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/6227c1ec866f8b00070a8603

😎 Browse the preview: https://deploy-preview-362--basestore.netlify.app

@vtex-sites
Copy link

vtex-sites bot commented Feb 22, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://preview-362--base.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 55937aa

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 22, 2022

Gatsby Cloud Build Report

basestore

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 86
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 93

🔗 View full report

@eduardoformiga eduardoformiga changed the title Chore: tweaks PLP skeleton loading criteria Chore: tweaks PLP loading Feb 22, 2022
@eduardoformiga eduardoformiga marked this pull request as ready for review February 22, 2022 23:02
@eduardoformiga eduardoformiga changed the title Chore: tweaks PLP loading Chore: tweaks PLP loading [FSSS-211] Feb 22, 2022
Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job! 💯

Just noticed a strange scroll behavior that I'm not sure if is correct:

  • When selecting some facet the page scrolls to the top (desktop version);
Screen.Recording.2022-02-23.at.01.03.45.mov
  • When opening the Filter component the page scrolls to the top (mobile version).
Screen.Recording.2022-02-23.at.01.02.47.mov

Is it expected?

@eduardoformiga
Copy link
Member Author

LGTM, nice job! 💯

Just noticed a strange scroll behavior that I'm not sure if is correct:

  • When selecting some facet the page scrolls to the top (desktop version);

Screen.Recording.2022-02-23.at.01.03.45.mov

  • When opening the Filter component the page scrolls to the top (mobile version).

Screen.Recording.2022-02-23.at.01.02.47.mov
Is it expected?

Nice catch! I think it's not expected.
But is also something not related to the changes on this PR since we can simulate on https://base.vtex.app/office as well.
I'm going to look into what is happening 👀

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eduardoformiga eduardoformiga merged commit 55937aa into master Mar 8, 2022
@eduardoformiga eduardoformiga deleted the chore/tweaks-plp-skeleton-loading-criteria branch March 8, 2022 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants