This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
refactor: Merge configs into a single file #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 7631b75 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/61aa7142d8067f0008c4bb96 😎 Browse the preview: https://deploy-preview-127--basestore.netlify.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-127--base.preview.vtex.app |
icazevedo
approved these changes
Dec 3, 2021
store.config.js
Outdated
| // Lighthouse CI | ||
| lighthouse: { | ||
| server: process.env.BASE_SITE_URL || 'http://localhost:9000', | ||
| urls: ['/', '/women', '/organza-sleeve-top-138/p'], |
There was a problem hiding this comment.
To keep it consistent with the cypress config
Suggested change
| urls: ['/', '/women', '/organza-sleeve-top-138/p'], | |
| pages: ['/', '/women', '/organza-sleeve-top-138/p'], |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR merges all config into a single file. The main idea behind this PR is to make it easier for stores to setup their repo after forking this repo. Also, it makes it easier to automate this task
How it works?
This PR merges config from lighthouse/cypress/api into a file called
store.config.jsand split it into sections.How to test it?
Make sure all features are working as intended