Add OnSKUSelected to props #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucis
reviewed
Oct 24, 2018
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - Add onSKUSelected to props and call it when its defined. | |||
There was a problem hiding this comment.
Specify for which component you did this, since you are in a common repo
lucis
approved these changes
Oct 24, 2018
brunojdo
force-pushed
the
fix/skuselected
branch
from
f424719 to
d885372
Compare
brunojdo
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Improve the reusability of the SKUSelector component
What problem is this solving?
It was impossible to define a behavior other than a redirect to the SKU's page when a SKU was selected
How should this be manually tested?
Access this workspace
Types of changes