Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable country when editing existing address #303

Merged

Conversation

beatrizmaselli
Copy link

@beatrizmaselli beatrizmaselli commented Jul 8, 2024

What did you change? *

When editing an existing address the user should not be able to edit the country of this address.

Why? *

For profile V2 addresses schema we can not change the country of an existing address because the schema is different per country so we are disabling this option when editing an address to be compliant with this structure.

How to test it? *

Test at this workspace: https://country--dunnesstoresqa.myvtex.com/account#/addresses
You may need to relink the version from this branch.

Before:

Screen.Recording.2024-07-08.at.18.55.38.mov

After:

Screen.Recording.2024-07-08.at.18.52.13.mov

Types of changes *

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical improvements

Copy link
Contributor

vtex-io-ci-cd bot commented Jul 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@lpolon
Copy link

lpolon commented Jul 8, 2024

Feliz que funcionou. LGTM 👍🏼

Copy link
Contributor

@wagnerlduarte wagnerlduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beatrizmaselli beatrizmaselli merged commit ea6de6e into 1.x Jul 9, 2024
4 of 5 checks passed
@beatrizmaselli beatrizmaselli deleted the Fix/country-field-disabling-when-edit-existing-address branch July 9, 2024 14:26
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 9, 2024

Your PR has been merged! App is being published. 🚀
Version 1.28.0 → 1.29.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.my-account@1.29.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants