Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RISC-V #76

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Add support for RISC-V #76

merged 2 commits into from
Jan 16, 2023

Conversation

yuzibo
Copy link

@yuzibo yuzibo commented Jan 9, 2023

This is PR duplicated from
#75
All code from Andreas Schwab schwab@suse.de

Signed-off-by: Andreas Schwab schwab@suse.de

This is PR duplicated from
vstinner#75
All code from Andreas Schwab <schwab@suse.de>

Signed-off-by: Andreas Schwab <schwab@suse.de>
@yuzibo
Copy link
Author

yuzibo commented Jan 9, 2023

First I hope this is a right way to send another PR based on others' PR on github.
In my understanding, I have no permission to edit/update commit on others' PR.

I have fixed some formatting issues and run test cases on my Unmatched board.
Please let me know if there is any issues.
Thanks.

@spoutn1k
Copy link
Collaborator

spoutn1k commented Jan 9, 2023

It will work. Thank you for your work and being respectful of Andreas'. I pushed a fix for the github workflows, and if @vstinner does not merge it in the week, I will.

@yuzibo
Copy link
Author

yuzibo commented Jan 10, 2023

Many thanks.

Btw, do we have plan to support python3.11 also(your commit hit me)? This time I build&test python-ptrace on python3.11:

...
OK
pep8 inst-nodeps: /home/vimer/build/python/python-ptrace/python-ptrace/.tox/.tmp/package/1/python-ptrace-0.9.9.zip
pep8 installed: flake8==6.0.0,mccabe==0.7.0,pycodestyle==2.10.0,pyflakes==3.0.1,python-ptrace @ file:///home/vimer/build/python/python-ptrace/python-ptrace/.tox/.tmp/package/1/python-ptrace-0.9.9.zip
pep8 run-test-pre: PYTHONHASHSEED='3171247802'
pep8 run-test: commands[0] | flake8 ptrace/ tests/ gdb.py runtests.py setup_cptrace.py setup.py strace.py SYSCALL_PROTOTYPES.codegen.py test_doc.py
________________________________________________________________ summary ________________________________________________________________
  py3: commands succeeded
  pep8: commands succeeded
  congratulations :)
vimer@dev-rv-unmatched:~/build/python/python-ptrace/python-ptrace$ python3 --version
Python 3.11.1
vimer@dev-rv-unmatched:~/build/python/python-ptrace/python-ptrace$ uname -a
Linux dev-rv-unmatched 6.1.0-1-riscv64 #1 SMP Debian 6.1.4-1 (2023-01-07) riscv64 GNU/Linux

AFAIK, Debian maybe uses python3.11 as the default version for bookworm(Although there is still debate, but they really did a lot of work for this). I think more and more linux distributions will use python3.11.

So, I can send PR after the PR can be merged if this makes sense. There is no extra work to do here.:)

@spoutn1k
Copy link
Collaborator

I don't see why not ! If you would like to push a PR be my guest. There may be some references to the python version to update in the documentation as well.

@yuzibo
Copy link
Author

yuzibo commented Jan 14, 2023

OK, will do.:)

@spoutn1k spoutn1k merged commit 0a721c8 into vstinner:main Jan 16, 2023
@spoutn1k spoutn1k mentioned this pull request Jan 31, 2023
@yuzibo yuzibo deleted the support-riscv64 branch February 4, 2023 23:08
@vstinner
Copy link
Owner

vstinner commented Apr 5, 2023

Nice contribution! Thanks. What's your use case for python-ptrace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants