Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plane position and normal constructor #993

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

AnyOldName3
Copy link
Contributor

It wouldn't actually compile, but thanks to SFINAE, it wasn't emitting an error unless you actually tried using it, which apparently nothing was. The initialiser wanted to receive a float, but because VSG's operator* works component-wise, it was getting a vector. I assume this was just an oversight when copying stuff from OSG where operator* is a dot product.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

vsg::plane reflectionPlane(vsg::vec3(0.0f, 5.0f, 0.0f), vsg::vec3(0.0f, -1.0f, 0.0f));

This line previously wouldn't compile, and now it does.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

It wouldn't actually compile, but thanks to SFINAE, it wasn't emitting
an error unless you actually tried using it, which apparently nothing
was.
@robertosfield robertosfield merged commit a79b02a into vsg-dev:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants