Merge changes in VSG master into 1.0 branch in prep for 1.0.8 release #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo in BufferView.h
…resentation(..) methods
Replaced WindowTraits::sharedWindow with Window::device, and added Viewer::removeWindow(..) method.
The template is officially defined in type_traits. I thought that this was causing a compilation problem with clang; it turns out it wasn't, but we can't depend on it being magically defined somewhere else.
include type_traits for std::is_floating_point_v
…rator::assignUnfirom/assignTexture
…Layout(...) and ShaderSet::createPipelineLayout(..) methods to help with creation of pipeline layouts indepdently from GraphcisPipelineConfigurator
Invalid layerCount was passed to vkCmdBlitImage when generating mipmaps for an array texture. In the code that loops over arrayLayers and blits each layer, layerCount should have been set to 1, not arrayLayers. Fixed by removing the loop. Let Vulkan loop over the image layers using a single blit of baseArrayLayer=0, layerCount=arrayLayers. Test case: auto imageData = vsg::ubvec4Array3D::create(256, 256, 32, vsg::ubvec4(), vsg::Data::Properties(VK_FORMAT_R8G8B8A8_UNORM)); imageData->properties.imageViewType = VK_IMAGE_VIEW_TYPE_2D_ARRAY; sampler->maxLod = 4; // Generate mipmaps
[FIXED] VK_LOD_CLAMP_NONE computed mipmap levels
Also, add a comment to createPipelineLayout
Deal with "missing" descriptor sets in ShaderSet::assignDescriptor
…sferTask Tested dynamic image updates Tested array texture mipmaps
Multi descriptor set configuration support in DestriptorConfigurator and GraphicsPipelineConfigurator.
[FIXED] array texture mipmaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.