Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy and clone for view and projection matrix #1299

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

rms7326
Copy link

@rms7326 rms7326 commented Oct 11, 2024

Description

We were trying to clone the view and projection matrices.

Type of change

Enhancement

Please delete options that are not relevant.

  • Filled out missing clone() method for several matrices.

How Has This Been Tested?

Without these implementations the object's clone base class simply returns a copy of the pointer. Now it performs an actual copy of the objects. Similar implementation to many many classes in VSG. I don't see any tests for cloning of other objects.

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] My changes generate no new warnings
  • [ x ] New and existing unit tests pass locally with my changes

…iew matrix and Perspective, and Orthographic projections
@robertosfield robertosfield merged commit 57689a6 into vsg-dev:master Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants