Update quat.h #1209
Merged
Update quat.h #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If from and to vectors are close to being opposite, it is not handled properly. For example, if from is (0,0,1) and to is (0,0,-1) the dot product is -1 this will imply that the axis will be (0,0,0), the length = 0 and the inversenorm will be infinite. For the solution, note that div is always greater than dot_pd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If from and to vectors are close to being opposite, it is not handled properly. For example, if from is (0,0,1) and to is (0,0,-1) the dot product is -1 this will imply that the axis will be (0,0,0), the length = 0 and the inversenorm will be infinite.
For the proposed solution, note that div is always greater or equal than dot_pd