Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONAI v1.3.0 #248

Closed
2 tasks
laraPPr opened this issue Dec 19, 2023 · 6 comments
Closed
2 tasks

MONAI v1.3.0 #248

laraPPr opened this issue Dec 19, 2023 · 6 comments
Assignees
Labels
conda Is supported in conda container Container image available difficulty: medium software that likely require a fair amount of effort to support easyconfig Easyconfig is available priority: medium Python site:t1_ugent_hortense Software installation request for Tier-1 Hortense update

Comments

@laraPPr
Copy link
Collaborator

laraPPr commented Dec 19, 2023

@laraPPr laraPPr added difficulty: medium software that likely require a fair amount of effort to support priority: medium Python update site:t1_ugent_hortense Software installation request for Tier-1 Hortense conda Is supported in conda container Container image available easyconfig Easyconfig is available labels Dec 19, 2023
@PetrKralCZ PetrKralCZ self-assigned this Jan 26, 2024
PetrKralCZ added a commit that referenced this issue Jan 26, 2024
PetrKralCZ added a commit that referenced this issue Jan 30, 2024
PetrKralCZ added a commit that referenced this issue Jan 31, 2024
PetrKralCZ added a commit that referenced this issue Feb 6, 2024
@boegel
Copy link
Contributor

boegel commented Feb 13, 2024

PetrKralCZ added a commit that referenced this issue Feb 19, 2024
PetrKralCZ added a commit that referenced this issue May 7, 2024
@PetrKralCZ
Copy link
Collaborator

Surprisingly MONAI (easybuilders/easybuild-easyconfigs#20494) build fails with:

/apps/gent/RHEL8/cascadelake-ib/software/pybind11/2.11.1-GCCcore-12.3.0/include/pybind11/detail/../cast.h:45:120: error: expected template-name before < token
         45 |     return caster.operator typename make_caster<T>::template cast_op_type<T>();
            |                                                                                                                        ^
      /apps/gent/RHEL8/cascadelake-ib/software/pybind11/2.11.1-GCCcore-12.3.0/include/pybind11/detail/../cast.h:45:120: error: expected identifier before < token
      /apps/gent/RHEL8/cascadelake-ib/software/pybind11/2.11.1-GCCcore-12.3.0/include/pybind11/detail/../cast.h:45:123: error: expected primary-expression before > token
         45 |     return caster.operator typename make_caster<T>::template cast_op_type<T>();
            |                                                                                                                           ^
      /apps/gent/RHEL8/cascadelake-ib/software/pybind11/2.11.1-GCCcore-12.3.0/include/pybind11/detail/../cast.h:45:126: error: expected primary-expression before ) token
         45 |     return caster.operator typename make_caster<T>::template cast_op_type<T>();
            |                                                                                                                              ^

The non-CUDA version works and these are the only differences:

--- /user/gent/453/vsc45304/easyconfigs/m/MONAI/MONAI-1.3.0-foss-2023a.eb       2024-02-13 14:26:27.200431393 +0100
+++ MONAI-1.3.0-foss-2023a-CUDA-12.1.1.eb       2024-05-07 10:21:18.970757232 +0200
@@ -2,6 +2,7 @@
 
 name = 'MONAI'
 version = '1.3.0'
+versionsuffix = '-CUDA-%(cudaver)s'
 
 homepage = 'https://monai.io/'
 description = """
@@ -19,16 +20,17 @@
 ]
 
 dependencies = [
+    ('CUDA', '12.1.1', '', SYSTEM),
     ('Python', '3.11.3'),
     ('Python-bundle-PyPI', '2023.06'),
     ('SciPy-bundle', '2023.07'),
-    ('PyTorch', '2.1.2'),
+    ('PyTorch', '2.1.2', versionsuffix),
     ('einops', '0.7.0'),
     ('ITK', '5.3.0'),
     ('NiBabel', '5.2.0'),
     ('scikit-image', '0.22.0'),
     ('tensorboard', '2.15.1'),
-    ('torchvision', '0.16.0'),
+    ('torchvision', '0.16.0', versionsuffix),
     ('tqdm', '4.66.1'),
     ('Pillow', '10.0.0'),
     ('openslide-python', '1.3.1'),

@boegel
Copy link
Contributor

boegel commented May 7, 2024

@lexming Does this happen to ring any bells for you?

@lexming
Copy link
Collaborator

lexming commented May 8, 2024

The issue is not with MONAI but pybind11, I suggest to reinstall pybind11 in the cascadelakes. That installation might lack some patches, like easybuilders/easybuild-easyconfigs#19047

@boegel
Copy link
Contributor

boegel commented May 23, 2024

Thanks a lot for the help on this one @lexming!

@PetrKralCZ PRs merged, software installed, ready for cleanup & closing...

PetrKralCZ added a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Is supported in conda container Container image available difficulty: medium software that likely require a fair amount of effort to support easyconfig Easyconfig is available priority: medium Python site:t1_ugent_hortense Software installation request for Tier-1 Hortense update
Projects
None yet
Development

No branches or pull requests

4 participants