Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types not available in 3.0.0 #56

Closed
4 tasks done
zm-cttae opened this issue Dec 25, 2023 · 1 comment
Closed
4 tasks done

Types not available in 3.0.0 #56

zm-cttae opened this issue Dec 25, 2023 · 1 comment

Comments

@zm-cttae
Copy link
Member

zm-cttae commented Dec 25, 2023

🐛 Bug Report

  • I'm using the latest version of vscode-textmate-languageservice available.
  • I searched existing issues, open & closed. Yes, my issue is new.

Describe the bug

Types are not available in 3.0.0.

Reproduction / log

'TextmateLanguageService' is declared but its value is never read.ts(6133)
Could not find a declaration file for module 'vscode-textmate-languageservice'. 'd:/Documents/Code/discord-vscode/node_modules/vscode-textmate-languageservice/dist/src/main.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/vscode-textmate-languageservice` if it exists or add a new declaration (.d.ts) file containing `declare module 'vscode-textmate-languageservice';`ts(7016)

Screenshot / blame

https://github.com/vsce-toolroom/vscode-textmate-languageservice/blob/v3.0.0/package.json#L38

Possible solution

  • Hotfix for the type declaration path in the package manifest - ./dist/types/main.d.ts.
  • Add regression test for types property in the package manifest.

Additional context

  • VS Code version: 1.85.1
  • Dependent extension ID: icrawl.discord-vscode
  • OS version: Windows 11 2H22
@zm-cttae
Copy link
Member Author

This is now out, sorry for the delay! Codacy was acting up, still acting up actually..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant