Skip to content

Commit

Permalink
[dotnet] use copyOnly for .png files in templates
Browse files Browse the repository at this point in the history
Context: dotnet/templating#3325
Context: https://github.com/dotnet/templating/wiki/Reference-for-template.json#content-manipulation

In current .NET 6 Preview 6 builds, there is an issue if a template
includes a binary file larger than ~8kb, it seems to get truncated when
`dotnet new` extracts the template.

A workaround is to use the `copyOnly` feature for binary files. Really,
we should be doing this anyway, because otherwise the templating system
considers replacing *text* in these binary files. It improves
performance to do this and would hopefully prevent a future bug of
random bytes getting replaced.
  • Loading branch information
jonathanpeppers authored and vs-mobiletools-engineering-service2 committed Jun 25, 2021
1 parent b1562dc commit c4c7457
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
"type": "project"
},
"sourceName": "MacCatalystApp1",
"sources": [
{
"source": "./",
"target": "./",
"copyOnly": "**/*.png"
}
],
"preferNameDirectory": true,
"primaryOutputs": [
{ "path": "MacCatalystApp1.csproj" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
"type": "project"
},
"sourceName": "iOSApp1",
"sources": [
{
"source": "./",
"target": "./",
"copyOnly": "**/*.png"
}
],
"preferNameDirectory": true,
"primaryOutputs": [
{ "path": "iOSApp1.csproj" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
"type": "project"
},
"sourceName": "macOSApp1",
"sources": [
{
"source": "./",
"target": "./",
"copyOnly": "**/*.png"
}
],
"preferNameDirectory": true,
"primaryOutputs": [
{ "path": "macOSApp1.csproj" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
"type": "project"
},
"sourceName": "tvOSApp1",
"sources": [
{
"source": "./",
"target": "./",
"copyOnly": "**/*.png"
}
],
"preferNameDirectory": true,
"primaryOutputs": [
{ "path": "tvOSApp1.csproj" }
Expand Down

0 comments on commit c4c7457

Please sign in to comment.