[Feature] FileInput controlled state without file data #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
force-pushed
the
feature/file-input-pseudofile-support
branch
from
183c9ed to
20b42d1
Compare
riitasointi
approved these changes
Feb 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings a new feature to FileInput, which allows it to be used in controlled state without having to store the actual file data in the component state. This can be accomplished by providing the component with an object with the necessary metadata, and storing the actual file elsewhere.
Motivation and Context
This was a request from several projects, where there were forms with possibly tens of files added. Storing the actual file data in the component state got really unoptimal in those cases.
How Has This Been Tested?
Tested locally on styleguidist on chrome as well as in a React+Vite test project. Also tested in one of the projects that requested this feature.
Release notes
FileInput
ControlledFileItem