CRE-587 Add Language Method Stubs #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
| @@ -382,6 +383,7 @@ private void DrawPlayerControllerSettings() | |||
| _settings.invertMouseLook = EditorGUILayout.Toggle(_invertMouseLookGuiContent, _settings.invertMouseLook); | |||
| _settings.playerHeight = EditorGUILayout.FloatField(_playerHeightGuiContent, _settings.playerHeight); | |||
| _settings.playerHeight = Mathf.Clamp(_settings.playerHeight, 0.2f, 80f); // TODO make consts for these. | |||
| _settings.currentLanguage = EditorGUILayout.TextField(_currentLanguageGuiContent, _settings.currentLanguage); | |||
There was a problem hiding this comment.
Could we make this a dropdown field instead of write-in?
There was a problem hiding this comment.
Good idea, done.
momo-the-monster
approved these changes
Jul 19, 2023
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for https://github.com/vrchat/vrchat/pull/6877. Adds stubs for the new language methods to client sim so they can be tested in editor. The user can set the currently selected language in the client sim settings window.