Add cesium ext structural metadata #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpenades
reviewed
Dec 5, 2023
vpenades
reviewed
Dec 22, 2023
bertt
commented
Dec 22, 2023
| }, | ||
| "extensions": {}, | ||
| "extras": {} | ||
| } |
There was a problem hiding this comment.
To check: Here the OneOf construction is removed temporarily to make the code generator working. See https://github.com/CesiumGS/glTF/blob/proposal-EXT_structural_metadata/extensions/2.0/Vendor/EXT_structural_metadata/schema/glTF.EXT_structural_metadata.schema.json#L53
vpenades
reviewed
Dec 23, 2023
vpenades
reviewed
Dec 23, 2023
vpenades
reviewed
Dec 23, 2023
vpenades
reviewed
Dec 23, 2023
|
So, if you don't plan to add anything else, it's fine by me to merge, let me know. |
|
Yes it’s finished, ok to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Cesium extension EXT_structural_metadata
PR at Khronos: KhronosGroup/glTF#2151
Spec: https://github.com/CesiumGS/glTF/tree/proposal-EXT_structural_metadata/extensions/2.0/Vendor/EXT_structural_metadata
Samples: https://github.com/CesiumGS/3d-tiles-samples/tree/main/glTF/EXT_structural_metadata