Ensure Puppetfile gets parsed with absolute path #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
use-absolute-path
branch
from
916565a to
734079e
Compare
sigv
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
The R10K docs are not too explicit in this, but they do indeed seem to want the basedir to be absolute. This matters if you use install_path in your Puppetfile but there might as well be other cases.
|
From #18, for a minimal Puppetfile to reproduce the issue: forge 'https://forgeapi.puppetlabs.com'
mod 'puppetlabs-stdlib',
:git => 'git@github.com:puppetlabs/puppetlabs-stdlib.git',
:tag => '4.25.0',
:install_path => 'external' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18.