Facts revamp with datatables. #357

redref · 2017-02-05T20:11:19Z

Like inventory, ordering by fact value is not possible for facts.

On /facts -

removed environment filtering as this request was really long with a lot of nodes (now, it would be possible to get a link to an empty table)
reworked column repartition in python to fix jinja >= 2.9 behavior (2.9 regression when assigning a variable inside a loop pallets/jinja#641)

On /fact

push everything into datatables (AJAX) - which save much time in DOM parsing and keep interface responsive during loading time
make datatables JSON call to also feed C3.js chart data if chart enabled

On /node

switch to datatables
mutualize JSON call code with /fact backend endpoint

coveralls · 2017-02-05T20:14:30Z

Coverage increased (+7.3%) to 76.504% when pulling ba135ba on redref:facts into 35486e8 on voxpupuli:master.

redref · 2017-02-05T20:29:09Z

Port of #356 fix with the new template.

Add this case to the tests.

coveralls · 2017-02-05T20:30:15Z

Coverage increased (+6.7%) to 75.931% when pulling 1ddeacb on redref:facts into 35486e8 on voxpupuli:master.

coveralls · 2017-02-05T20:30:15Z

Coverage increased (+6.7%) to 75.931% when pulling 1ddeacb on redref:facts into 35486e8 on voxpupuli:master.

redref · 2017-02-05T21:18:09Z

On #356 subject.

Python3 returned me

    return sorted(map(_GroupTuple, groupby(sorted(value, key=expr), expr)))
TypeError: unorderable types: bool() < str()

Solved by adding a jinja2 filter used in a map before groupby.

coveralls · 2017-02-05T21:18:49Z

Coverage increased (+7.4%) to 76.605% when pulling 4d522d8 on redref:facts into 35486e8 on voxpupuli:master.

redref · 2017-02-15T21:20:19Z

Rebased.

coveralls · 2017-02-15T21:25:47Z

Coverage increased (+7.2%) to 81.728% when pulling 31173ff on redref:facts into fd4051b on voxpupuli:master.

coveralls · 2017-02-15T21:35:09Z

Coverage increased (+7.2%) to 81.728% when pulling 8e2d441 on redref:facts into fd4051b on voxpupuli:master.

tux-o-matic · 2017-03-23T15:15:11Z

JSON is a first class citizen in Python, why choose to generate JSON in a template rather than pure Python code in the fact_ajax function?

redref · 2017-03-23T19:38:40Z

Honestly, I don't know. Now that you said it, it really seems legit.

mterzo · 2017-03-23T20:30:28Z

If the data isn't quite the same as you want in the client the template makes some sense.

redref · 2017-03-23T20:34:07Z

No preference on my side. Let me know if you prefer me to amend those PR's or if you think we can postpone it to do all of these in one pass.

corey-hammerton · 2017-03-23T20:37:33Z

puppetboard/app.py

    node for which this fact is known.

    :param env: Searches for facts in this environment
    :type env: :obj:`string`
    :param fact: Find all facts with this name
    :type fact: :obj:`string`
+    :param fact: Find all facts with this value
+    :type fact: :obj:`string`


This doc should reference the value parameter, not the fact parameter.

corey-hammerton · 2017-03-23T20:40:17Z

In the long run if the python can directly output JSON data then that's far less code for this project to maintain.

Removed facts query to let only fact-names. facts query time grow pretty quickly with number of nodes. Drawback: no filter on environment (which seems acceptable) Add testing about view and column repartition (broken in jinja2 2.9.X / inner loop variables). Rework facts page (jinja 2.9 compliant)

Created a custom template_filter as in python3, the groupby filter cannot order Bool vs Str. Needed to push format before the groupby which is not currently possible in jinja.

coveralls · 2017-03-23T22:11:06Z

Coverage increased (+7.7%) to 81.356% when pulling e39d8f0 on redref:facts into e76fdb5 on voxpupuli:master.

coveralls · 2017-03-23T22:11:06Z

Coverage increased (+7.7%) to 81.356% when pulling e39d8f0 on redref:facts into e76fdb5 on voxpupuli:master.

coveralls · 2017-03-23T22:17:22Z

Coverage increased (+7.2%) to 80.791% when pulling f02ea7a on redref:facts into e76fdb5 on voxpupuli:master.

redref · 2017-03-23T22:23:41Z

Refactored JSON generation in python. It is cleaner than jinja for sure.

Also rebased on master.

coveralls · 2017-03-23T22:28:03Z

Coverage increased (+7.1%) to 80.737% when pulling c1fd33f on redref:facts into e76fdb5 on voxpupuli:master.

coveralls · 2017-04-03T20:42:48Z

Coverage increased (+7.7%) to 81.303% when pulling d2c47df on redref:facts into e76fdb5 on voxpupuli:master.

coveralls · 2017-06-10T07:42:33Z

Coverage increased (+3.2%) to 80.417% when pulling 7cd8908 on redref:facts into 26825ae on voxpupuli:master.

redref force-pushed the facts branch from 1ddeacb to 4d522d8 Compare February 5, 2017 21:16

mterzo added this to the 0.3.0 milestone Feb 6, 2017

redref force-pushed the facts branch from 4d522d8 to 31173ff Compare February 15, 2017 21:20

redref force-pushed the facts branch from 31173ff to 8e2d441 Compare February 15, 2017 21:24

corey-hammerton reviewed Mar 23, 2017

View reviewed changes

redref added 4 commits March 23, 2017 22:35

Revamp fact pages and tables to datatables

a21bd0a

Fact pages and node page tests

40511c0

Fix voxpupuli#356 with the new template

484727b

Created a custom template_filter as in python3, the groupby filter cannot order Bool vs Str. Needed to push format before the groupby which is not currently possible in jinja.

redref force-pushed the facts branch from 8e2d441 to e39d8f0 Compare March 23, 2017 22:08

redref added 3 commits March 23, 2017 23:12

Fix facts method doc

4b96cfe

Clean CatalogForm

d4d7b6a

Fix tox deps

b17a2b0

redref force-pushed the facts branch from e39d8f0 to f02ea7a Compare March 23, 2017 22:13

Generate fact JSON directly in python

c1fd33f

redref force-pushed the facts branch from f02ea7a to c1fd33f Compare March 23, 2017 22:21

Fix link formatting

d2c47df

Merge branch 'master' into facts

7cd8908

mterzo merged commit 38b2a2f into voxpupuli:master Jun 10, 2017

redref deleted the facts branch June 10, 2017 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Facts revamp with datatables. #357

Facts revamp with datatables. #357

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017 •

edited

Loading

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017

coveralls commented Feb 5, 2017 •

edited

Loading

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017 •

edited

Loading

redref commented Feb 15, 2017

coveralls commented Feb 15, 2017 •

edited

Loading

coveralls commented Feb 15, 2017 •

edited

Loading

tux-o-matic commented Mar 23, 2017

redref commented Mar 23, 2017

mterzo commented Mar 23, 2017

redref commented Mar 23, 2017

corey-hammerton Mar 23, 2017

corey-hammerton commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Mar 23, 2017

redref commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Apr 3, 2017 •

edited

Loading

coveralls commented Jun 10, 2017 •

edited

Loading

Facts revamp with datatables. #357

Facts revamp with datatables. #357

Conversation

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017 • edited Loading

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017

coveralls commented Feb 5, 2017 • edited Loading

redref commented Feb 5, 2017

coveralls commented Feb 5, 2017 • edited Loading

redref commented Feb 15, 2017

coveralls commented Feb 15, 2017 • edited Loading

coveralls commented Feb 15, 2017 • edited Loading

tux-o-matic commented Mar 23, 2017

redref commented Mar 23, 2017

mterzo commented Mar 23, 2017

redref commented Mar 23, 2017

corey-hammerton Mar 23, 2017

Choose a reason for hiding this comment

corey-hammerton commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Mar 23, 2017

redref commented Mar 23, 2017

coveralls commented Mar 23, 2017

coveralls commented Apr 3, 2017 • edited Loading

coveralls commented Jun 10, 2017 • edited Loading

coveralls commented Feb 5, 2017 •

edited

Loading

coveralls commented Feb 5, 2017 •

edited

Loading

coveralls commented Feb 5, 2017 •

edited

Loading

coveralls commented Feb 15, 2017 •

edited

Loading

coveralls commented Feb 15, 2017 •

edited

Loading

coveralls commented Apr 3, 2017 •

edited

Loading

coveralls commented Jun 10, 2017 •

edited

Loading