Track known-bad os and puppet combinations

[smortex]

This is used to avoid running acceptance tests on systems where versions
of Puppet are not supported (yet or anymore).

[ekohl]

So the idea is to emit this too and then in the Github action you add an exclude with them? I wonder how this compares not emitting them in the first place. I guess either of them could work.

Slight note: you're missing the Fedora builds.

[ekohl]

Suggested change

	supporder_versions = {
	supporded_versions = {

[smortex]

Suggested change

	supporder_versions = {
	supported_versions = {

🙃

[ekohl]

Perhaps this should be something like AIO_BUILDS

[ekohl]

So the idea is to emit this too and then in the Github action you add an exclude with them? I wonder how this compares not emitting them in the first place. I guess either of them could work.

I took a stab at this myself but that would really change the current approach. Instead of feeding it 2 vectors, you'd need to pass it an include block.

I also thought about the logic and I came up with:

module PuppetMetadata
  class AIO 
    BUILDS = { 
      # RPM-based
      'CentOS' => {
        '5' => 5..7,
        '6' => 5..7,
        '7' => 5..7,
        '8' => 5..7,
      },
      'Fedora' => {
        '26' => [5],
        '27' => 5..6,
        '28' => 5..6,
        '29' => 5..6,
        '30' => 5..7,
        '31' => 5..7,
        '32' => 6..7,
        '34' => 6..7,
      },
      # TODO: SLES/Suse
      # deb-based
      'Debian' => {
        '7' => [5],
        '8' => 5..7,
        '9' => 5..7,
        '10' => 5..7,
      },
      'Ubuntu' => {
        '14.04' => 5..6,
        '16.04' => 5..7,
        '18.04' => 5..7,
        '20.04' => 6..7,
      },
    }

    def self.has_aio_build?(os, release, puppet_version)
      # TODO: group CentOS with RedHat/AlmaLinux/Rocky?
      BUILDS.dig(os, release)&.include?(puppet_version)
    end
  end
end

[smortex]

Generating only an include with all supported "known-good" combinations is probably better yes… If you have something, feel free to push it here (or in another PR and close this one). If not, I will try to have a look at it in the next few days.

[smortex]

Closing in favor of #21