Add ldap reqcert #560
Merged
Add ldap reqcert #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ekohl
reviewed
Nov 2, 2018
manifests/web.pp
Outdated
| @@ -151,6 +151,9 @@ | |||
| # [*ldap_clientkey*] | |||
| # Set location of client key used by LDAP authentication. | |||
| # | |||
| # [*ldap_reqcert *] | |||
| # Specifies what checks to perform on a server certificate ( never | allow | try | demand,hard ) | |||
There was a problem hiding this comment.
The demand,hard is a bit odd. However, since there's a data type I'd suggest to leave them out. If you generate a REFERENCE.md the data type should be enough.
There was a problem hiding this comment.
updated it. I checked the docs, demand and hard are independent values.
alexjfisher
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #378
Add the option to specify the ldap_reqcert this is needed in some SSL implementations