Skip to content

Commit

Permalink
Merge pull request #443 from bastelfreak/zabbix34
Browse files Browse the repository at this point in the history
Bump default zabbix version to 3.4 + test on it
  • Loading branch information
wyardley authored Sep 17, 2017
2 parents 125adcf + 5f6c487 commit ac3c78b
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion manifests/params.pp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
$zabbix_template_dir = '/etc/zabbix/imported_templates'
$zabbix_timezone = 'Europe/Amsterdam'
$zabbix_url = 'localhost'
$zabbix_version = '3.2'
$zabbix_version = '3.4'
$zabbix_web = 'localhost'
$zabbix_web_ip = '127.0.0.1'
$manage_database = true
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/agent_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'spec_helper_acceptance'

['2.4', '3.2'].each do |version|
['2.4', '3.2', '3.4'].each do |version|
if version == '2.4' && default[:platform] =~ %r{(ubuntu-16.04-amd64|debian-8-amd64)}
next
end
Expand Down
4 changes: 2 additions & 2 deletions spec/classes/agent_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@
it { is_expected.to raise_error(Puppet::Error, %r{Managing a repo on Archlinux is currently not implemented}) }
when 'Debian'
# rubocop:disable RSpec/RepeatedExample
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.4') }
it { is_expected.to contain_package('zabbix-agent').with_require('Class[Zabbix::Repo]') }
it { is_expected.to contain_apt__source('zabbix') }
when 'RedHat'
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.4') }
it { is_expected.to contain_package('zabbix-agent').with_require('Class[Zabbix::Repo]') }
it { is_expected.to contain_yumrepo('zabbix-nonsupported') }
it { is_expected.to contain_yumrepo('zabbix') }
Expand Down
6 changes: 3 additions & 3 deletions spec/classes/proxy_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
}
end

it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.4') }
it { is_expected.to contain_package('zabbix-proxy-pgsql').with_require('Class[Zabbix::Repo]') }
it { is_expected.to contain_yumrepo('zabbix-nonsupported') }
it { is_expected.to contain_yumrepo('zabbix') }
Expand Down Expand Up @@ -118,7 +118,7 @@
end

it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_type('proxy') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_version('3.4') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_name('zabbix_proxy') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_user('zabbix-proxy') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_password('zabbix-proxy') }
Expand All @@ -138,7 +138,7 @@
end

it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_type('proxy') }
it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_version('3.4') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_name('zabbix_proxy') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_user('zabbix-proxy') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_password('zabbix-proxy') }
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/sender_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
is_expected.to raise_error(Puppet::Error, %r{Managing a repo on Archlinux is currently not implemented})
end
else
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::repo').with_zabbix_version('3.4') }
it { is_expected.to contain_package('zabbix-sender').with_require('Class[Zabbix::Repo]') }
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/classes/server_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
end

it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_type('server') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_zabbix_version('3.4') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_name('zabbix-server') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_user('zabbix-server') }
it { is_expected.to contain_class('zabbix::database::postgresql').with_database_password('zabbix-server') }
Expand All @@ -97,7 +97,7 @@
end

it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_type('server') }
it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_version('3.2') }
it { is_expected.to contain_class('zabbix::database::mysql').with_zabbix_version('3.4') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_name('zabbix-server') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_user('zabbix-server') }
it { is_expected.to contain_class('zabbix::database::mysql').with_database_password('zabbix-server') }
Expand Down

0 comments on commit ac3c78b

Please sign in to comment.